gap icon indicating copy to clipboard operation
gap copied to clipboard

reordering parameters in calls of NewMatrix

Open cdwensley opened this issue 4 years ago • 1 comments

This PR addresses issue #4549 : "The two methods in matobj.gi have the following form: NewMatrix( filt, R, ncols, list ) and Matrix( filt, R, list, ncols ). This inconsistency is unacceptable in the long run."

Text for release notes

The ordering of arguments in the NewMatrix operation have been changed to agree with those used in Matrix. So NewMatrix( filt, R, ncols, list ) has been replaced by NewMatrix( filt, R, list, ncols ).

cdwensley avatar Jun 25 '21 15:06 cdwensley

I took the liberty of marking this PR to a draft, as it crucially relies on https://github.com/gap-packages/cvec/pull/34 (or a variant thereof) to be merged, released, and picked up by package distribution.

fingolfin avatar Jun 25 '21 23:06 fingolfin