PackageMaker icon indicating copy to clipboard operation
PackageMaker copied to clipboard

All contributors of the branch gh-gap show up on the front page of the github repository

Open mohamed-barakat opened this issue 5 years ago • 6 comments

If the gh-pages are created using PackageMaker then GitHub shows all contributors to the branch gh-gap on the front page of the repository. Here is an example:

https://github.com/homalg-project/CatReps

This list is persistent even after recreating the gh-pages branch from scratch.

I don't think this is desirable

mohamed-barakat avatar Oct 21 '20 17:10 mohamed-barakat

This is not specific to PackageMaker, this is a consequence of using GithubPagesForGAP. And, well, all those people did contribute.... But If it bothers you, you can discard the gh-pages history and start a fresh one, re-importing all files currently in there.

fingolfin avatar Oct 22 '20 06:10 fingolfin

I would even like it to see the contributors per branch, especially for the gh-pages branch which plays a different role.

The motivation for writing this issue was that I was really puzzled to see Pedro and Chris on the list of contributors as I forgot about the gh-pages branch and expected this to be a GitHub error (I expect to see you everywhere 😄). Even worse, if one clicks on the contributor's link there is no reference to them anymore and there is no option to change the branch. I expect this to puzzle other people as well since they won't have the gh-pages branch on their minds.

mohamed-barakat avatar Oct 22 '20 08:10 mohamed-barakat

... you can discard the gh-pages history and start a fresh one, re-importing all files currently in there.

I did this for the other packages but it is still persistent for CatReps, even though I recreated the gh-pages branch and force-pushed.

The acknowledgment for GitHubPagesForGAP is properly displayed on the bottom left corner here and I am happy with it. By clicking on the link one sees the corresponding list of contributors.

mohamed-barakat avatar Oct 22 '20 08:10 mohamed-barakat

I just wanted to draw your attention to this issue and you are free to close it.

mohamed-barakat avatar Oct 22 '20 09:10 mohamed-barakat

It is unclear to me what you are asking for, then. This sounds more like an issue with GitHub than with PackageMaker?

fingolfin avatar Oct 22 '20 10:10 fingolfin

To resolve this PackageMaker should be changed to not import the history of the GitHubPages repo but rather start with a fresh commit -- I used to be opposed to that because I thought it would be useful to be able to "pull updates" from GitHubPagesForGAP. But in practice doing that is rarely possible or easy; when trying to "update" package to a newer version of GitHubPagesForGAP it ends up requiring manual work anyway.

fingolfin avatar Apr 10 '25 07:04 fingolfin