unity-builder AWS Fargate S3 Bucket name issue

Bug description S3 bucket names should be unique but the base-setup.yml file contains hardcoded BucketName: game-ci-storage line which makes the template creation fail. https://raw.githubusercontent.com/game-ci/unity-builder/main/dist/cloud-formations/base-setup.yml

How to reproduce Follow the builder steps here.

We should either state this in the document or automate this process in code, maybe through build step parameters?

Jun 05 '21 13:06 edencakir

@edencakir indeed, looks like this should be fixed on builder side.

Are you able to provide the portion of the output that contains the error?

cc: @frostebite maybe we're able to accept the suggested name for the bucket and capture the output name?

Jun 05 '21 15:06 webbertakken

Will fix.

@webbertakken agreed, will look at supporting that.

Jun 05 '21 15:06 frostebite

@webbertakken after this event other services fail as well. changing the hardcoded value to a unique string fixed the issue. Screen Shot 2021-06-05 at 21 52 18

Jun 05 '21 18:06 edencakir

@frostebite I believe you had fixed this issue a while back already, correct?

Sep 10 '21 19:09 webbertakken

@frostebite could you please have a look at this issue?

May 22 '22 11:05 webbertakken

In the release branch cloud-runner-develop https://game.ci/docs/github-cloud-runner/configuration#release-branch-configuration

This has been resolved. The S3 bucket was never explicitly needed, so it's been removed. This happened if you deleted the "base cloud formation" and tried to re-run cloud runner, which reinstalls the base stack if it's missing. And AWS doesn't delete the S3 bucket to protect your data by default.

So this can also be fixed by just forcing the S3 bucket to delete and running again.

This will be in the main release branch when either of these are merged #459 #437.

Please feel welcomed to reopen a ticket @edencakir if you have any more questions or issues. 🙏

Sorry it took a little while to get back to you!

Oct 04 '22 23:10 frostebite