react-scrollable-anchor icon indicating copy to clipboard operation
react-scrollable-anchor copied to clipboard

Allow containers other than window to scroll

Open ajmas opened this issue 8 years ago • 9 comments

It would be useful to allow other containers to scroll, for where the main view is static, but it is an internal div that scrolls.

ajmas avatar Mar 27 '17 20:03 ajmas

I have a draft change here, but lacking example and documentation update, on my side, I am not ready to make a PR: https://github.com/ajmas/react-scrollable-anchor/tree/issue-2/src

ajmas avatar Mar 27 '17 20:03 ajmas

This improvement is definitely on my radar. Feel free to finish + test your change and throw up a PR. I might have time this week to give it a shot as well. If you have a particular use-case in mind, feel free to share it, and I can test against it.

gabergg avatar Mar 28 '17 17:03 gabergg

I'll see what I can do, though if you get to make a change before I make mine, then that's cool.

ajmas avatar Mar 28 '17 23:03 ajmas

@ajmas curious how you got on with this?

jjenzz avatar Nov 29 '17 16:11 jjenzz

@jjenzz I haven’t made much new progress, due to other priorities on my plate.

ajmas avatar Nov 29 '17 16:11 ajmas

@ajmas Any update on this?

gucolin avatar Feb 18 '18 23:02 gucolin

Haven’t had time to explore the issue much since. I would encourage anyone else to see if they can improve on this.

ajmas avatar Feb 18 '18 23:02 ajmas

Well seems your fix above have addressed it. Any chance you can throw it in? Thanks

gucolin avatar Feb 19 '18 00:02 gucolin

PR made: https://github.com/gabergg/react-scrollable-anchor/pull/37/

ajmas avatar Feb 19 '18 03:02 ajmas