JavaPackager icon indicating copy to clipboard operation
JavaPackager copied to clipboard

AppStream upstream metadata is missing

Open SaptarshiSarkar12 opened this issue 2 years ago • 9 comments

I'm submitting a…

  • [ ] bug report
  • [ ] feature request
  • [X] other

Short description of the issue/suggestion: When the Drifty application is packaged using JavaPackager Maven plugin via GitHub Action, it shows the below error 👇

WARNING: AppStream upstream metadata is missing, please consider creating it

How can I fix it?

Do you have outputs, screenshots, demos or samples which demonstrate the problem or enhancement? You can check the GitHub Action output to see the error.

Please tell us about your environment:

  • JavaPackager version: 1.7.2
  • OS version: ubuntu-22.04 (Ubuntu-latest for GitHub Action)
  • JDK version: 20.0.1
  • Build tool:
    • [X] Maven
    • [ ] Gradle

Other Information You can check the pom.xml file to see if any changes needs to be made in that.

SaptarshiSarkar12 avatar Jul 01 '23 05:07 SaptarshiSarkar12

@fvarrui Please look into the issue.

SaptarshiSarkar12 avatar Jul 01 '23 05:07 SaptarshiSarkar12

Hi @SaptarshiSarkar12!

I fear you can fix it ... unless you code a patch for JavaPackager and make a PR.

I'll take a look into it ASAP.

Anyway, it's showing a warning message, not an error. Have you tried to run the generated AppImage?

fvarrui avatar Jul 04 '23 23:07 fvarrui

Hi @SaptarshiSarkar12!

I fear you can fix it ... unless you code a patch for JavaPackager and make a PR.

I'll take a look into it ASAP.

Anyway, it's showing a warning message, not an error. Have you tried to run the generated AppImage?

@fvarrui Yes, the AppImage runs pretty well.

SaptarshiSarkar12 avatar Jul 05 '23 05:07 SaptarshiSarkar12

Thank you for giving your valuable time to resolve the issue!

SaptarshiSarkar12 avatar Jul 05 '23 05:07 SaptarshiSarkar12

@fvarrui Please check this docs of freedesktop about metadata file. It says to create a app_name.metadata.xml file in /usr/share/metainfo/ directory before building the AppImage. I think this file can be auto-created by JavaPackager before initiating the building of AppImages. So, it might be a good feature we should bring in this project. @fvarrui Let me know your opinion.

SaptarshiSarkar12 avatar Jul 11 '23 04:07 SaptarshiSarkar12

@SaptarshiSarkar12 Ok, I've just check this example and it seems that all required data is available in JP. As it's related to issue-345, and there's already a branch for this issue, changes will be made in this branch.

As far as I understand, this is not only for AppImage, but DEB and RPM too, right?

fvarrui avatar Jul 13 '23 12:07 fvarrui

@SaptarshiSarkar12 Ok, I've just check this example and it seems that all required data is available in JP. As it's related to issue-345, and there's already a branch for this issue, changes will be made in this branch.

As far as I understand, this is not only for AppImage, but DEB and RPM too, right?

Ok @fvarrui, that's great! No, there is some problems regarding DEB and might be RPM also. The problem is that the description shown by Software Install application in ubuntu (when trying to install DEB package) is not as what is provided to JavaPackager. Below are the required relevant screenshots and links :

Deb package in Software Install

Link to pom.xml : https://github.com/SaptarshiSarkar12/Drifty/blob/master/pom.xml

SaptarshiSarkar12 avatar Jul 13 '23 15:07 SaptarshiSarkar12

No, there is some problems regarding DEB and might be RPM also. The problem is that the description shown by Software Install application in ubuntu (when trying to install DEB package) is not as what is provided to JavaPackager.

So, do you mean that metadata file has also to be provided by DEB and RPM packages?

fvarrui avatar Jul 13 '23 15:07 fvarrui

No, there is some problems regarding DEB and might be RPM also. The problem is that the description shown by Software Install application in ubuntu (when trying to install DEB package) is not as what is provided to JavaPackager.

So, do you mean that metadata file has also to be provided by DEB and RPM packages?

Yeah @fvarrui, it might help. Also, the application icon is not present when opening DEB (might be the same case with RPM) through Software Install application in Ubuntu 23.04.

SaptarshiSarkar12 avatar Jul 13 '23 16:07 SaptarshiSarkar12