Missing "address-of" operator & in arm_reg_ptr function.

Open enlighten5 opened this issue 2 years ago • 2 comments

It looks to me that the arm_reg_ptr function is getting the reference of arm registers, but the reference operator & is missing when handling registers from R0 to R12 and D0 to D31, as shown in this fix.

Please let me know if this makes sense.

Regards.

Nov 27 '23 19:11 enlighten5

Hi enlighten5,

that makes sense. I think this was due to the fact that the API is used for the NVIC implementation which does not use the general purpose registers. If you like, you could create a pull request.

Tobi

Nov 29 '23 23:11 Scepticz

Sure, I've created a pull request.

Also, I am wondering if you plan to upgrade the unicorn emulator to the latest version.

I tried to port your changes to Unicorn to the latest version. but there are some crashes when running with the pipeline. I haven't looked into it yet but I guess it might be related to incompatibilities with the code in fuzzware_harness.

Dec 03 '23 00:12 enlighten5