node-protobuf icon indicating copy to clipboard operation
node-protobuf copied to clipboard

Remain unset optional fields with their default values.

Open shankerwangmiao opened this issue 8 years ago • 1 comments

Hi, in protobuf3, there are no required fields anymore. For numeric fields with value 0, the filed is serialized as unset and in this case, the parsed object will lack such fields. This patch removed detection for fields which are not present and let libprotobuf return the default value, as expected.

shankerwangmiao avatar Sep 06 '17 08:09 shankerwangmiao

My problem with this (and with proto3) is that you can no longer tell the difference between an unset field and a field that is set to the default value. There's also bound to be a perf impact here since it will now process all the fields even when not present in the message.

If this is merged please at least make it optional.

InfinitiesLoop avatar Oct 19 '17 19:10 InfinitiesLoop