Haoze Wu

> @functioner would you mind to add unit test to cover this improvement? I'm writing a unit test to cover this improvement. After I read the test cases of `TestEditLog`...

@Hexiaoqiao Thanks for the comment, I removed `logSyncNotifyExecutor.shutdown()`. I think we also need to add some comments in the code to show why we don't shutdown this executor, in case...

@Hexiaoqiao thanks for the reminder. I've added: 1. comments for removing `logSyncNotifyExecutor.shutdown()` 2. configuration for the size of `logSyncNotifyExecutor` 3. the docs for that configuration

@amahussein Thanks for the comment. Can I send an email to you to explain more about the issue? @Hexiaoqiao and I have some more discussion on it, and some discussion...

> If any concerns about lambda expression, we could improve it rather than reject it directly. @amahussein A common way to eliminate such overhead is preparing multiple consumer threads, and...

> In that case, please change the title of the Jira and the description to remove references to "hanging" problems. @amahussein I still would like to argue about this "hanging"...

> > In that case, please change the title of the Jira and the description to remove references to "hanging" problems. > > @amahussein I still would like to argue...

> Thanks @functioner > The detailed discussions (except the lambda argument) should have been on the Jira. I see. I will make a comment of summary in Jira after the...

> Thanks @functioner > The detailed discussions (except the lambda argument) should have been on the Jira. > > > IMO, this is a classic Producer-Consumer problem, and it is...

> No, it's a non-blocking write so by definition it will never hang – unless induced by fault injection. @daryn-sharp I have considered this counterargument in https://github.com/apache/hadoop/pull/2737#issuecomment-822591028, where I proposed...