codeina icon indicating copy to clipboard operation
codeina copied to clipboard

Packaging codeina as a codox theme

Open cldwalker opened this issue 10 years ago • 3 comments

Hi. I really like your theme and would like to use it for LightTable. However, I would like to use it with codox as a writer/theme because it is getting more usage and features. Would you be open to making codeina a codox theme clojar instead of a fork? I've discussed making codeina such a theme at https://github.com/weavejester/codox/issues/109 with @weavejester and he's open to promoting themes on codox's README. As shown in the screenshot of that issue, I have a fork of codox that uses your theme. Reusing codox's writer, the code to maintain shrinks down to just default.css and a few writer page fns. I'm happy to work with and submit a PR to you if there's interest. If there's no interest, we'll probably fork your fork and package it as a codox theme. Thanks for this library!

cldwalker avatar Dec 07 '15 17:12 cldwalker

Hi @cldwalker , codeina is not just a fork with different theme. It has a lot of internal changes for simplify the code base for proper reason about it and better understanding. Also, the cljs doc generator has been much improved in codeina.

I'm open to consider merging the projects to have one better. But making codeina just as "theme" of codox is not on my plans.

niwinz avatar Dec 07 '15 17:12 niwinz

@niwinz Understood and I'm aware codeina does more than styling so perhaps I should clarify my proposal. Is there interest in splitting out the codeina styling to a separate jar that is compatible with codox? I don't have an opinion on internal changes and improved doc generation. Those are changes you would have to work upstream with codox if you would like to merge.

cldwalker avatar Dec 07 '15 18:12 cldwalker

Before anything, I really want ask you: Why not just use codeina instead of codox? That thinks you are missing? Maybe is more easy add them to codeina...?

Furthermore, the styling of codeina is very very simple and surely taking it as is and put it in codox could be more simple that maintaining 2 jars I guess.

niwinz avatar Dec 07 '15 19:12 niwinz