react-native-oauth icon indicating copy to clipboard operation
react-native-oauth copied to clipboard
verified publisher icon fullstackreact

Remove override of createJSModules from OAuthManagerPackage.java

Open ujeenator opened this issue 8 years ago • 2 comments

The current version of React Native 0.47 has removed the createJSModules method in ReactPackage. Therefore any overrides of this method will need to be removed from the library, or this will cause a compilation error.

https://github.com/facebook/react-native/commit/ce6fb337a146e6f261f2afb564aa19363774a7a8

screen shot 2017-08-28 at 6 40 51 pm

ujeenator avatar Aug 28 '17 15:08 ujeenator

Yes, since RN 0.47 it's really necessary. I have to manually clean createJSModules every time.

freeworlder avatar Sep 02 '17 14:09 freeworlder

Yes please! Make a new release without the override annotation.

MBach avatar Nov 13 '17 10:11 MBach