react-native-firestack icon indicating copy to clipboard operation
react-native-firestack copied to clipboard
verified publisher icon fullstackreact

[v3] Extra "/" on database refs.

Open FrankSalad opened this issue 9 years ago • 4 comments

firestack.database().ref().child('test').path returns //test

FrankSalad avatar Jan 14 '17 23:01 FrankSalad

@chrisbianca very sloppy work on https://github.com/fullstackreact/react-native-firestack/commit/fec4b6e8ce00416a99afad299f6251c36ceded52

_handleDatabaseEvent still passes a list to the Reference constructor. https://github.com/fullstackreact/react-native-firestack/blob/v3/lib/modules/database/index.js#L195

FrankSalad avatar Jan 15 '17 00:01 FrankSalad

@FrankSalad thanks for highlighting.

Perhaps next time you can be a bit more polite about it.

chrisbianca avatar Jan 15 '17 08:01 chrisbianca

Noted. Please test before pushing code to branch? ❤️ ❤️ ❤️

Should I rely on v3 branch for production?

FrankSalad avatar Jan 17 '17 01:01 FrankSalad

@FrankSalad it's a dev branch not a release, if you're not happy with it then wait for a release thats production ready.

Most of us are happy using v3 branch considering the state that v2 is in.

Salakar avatar Jan 17 '17 11:01 Salakar