dotnet-starter-kit icon indicating copy to clipboard operation
dotnet-starter-kit copied to clipboard

Sourcegenerator

Open Stonne opened this issue 4 years ago • 6 comments

Added sourcegenerator code and files

Stonne avatar Apr 25 '22 05:04 Stonne

Super nice effort for sure!

But I'm not sure this should actually be a part of this repository. I think this is an excellent use case for a dotnet tool (in a separate repository), which could then be included in this repository as a nuget package (just like we have the ef core tooling included for instance).

I could be wrong though... Just thinking out loud here... anyone feel free to chime in ;-)

fretje avatar Apr 25 '22 09:04 fretje

I just notices there is a discussion going on in discussions.. I'm waiting for suggestions ...

Stonne avatar Apr 25 '22 10:04 Stonne

Great Effort! Thanks!

It would be better if we could move this to a separate repository. I created one for the same. https://github.com/fullstackhero/fsh-cli

This way, we can expand the Tooling usage for the Blazor project and make it more parameterized.

iammukeshm avatar Apr 25 '22 11:04 iammukeshm

Ok Will start this evening I'm traveling now

Stonne avatar Apr 25 '22 11:04 Stonne

Hi @Stonne , maybe create a issue/Discussion in the new fsh-cli repo, and create a roadmap, on what is done, waht you working

PedroVentura235 avatar Apr 25 '22 13:04 PedroVentura235

@Stonne - hi there - I looked in the source code for your generator - but do not see it. Could you direct me to where I could get it to stat my new project with.

Julianh9 avatar May 06 '22 06:05 Julianh9

You are right but this is how I understood it from the issues of feb 1 How should I take it from here ?

Op ma 25 apr. 2022 11:47 schreef fretje @.***>:

@.**** commented on this pull request.

In src/Utils/SourceGenerator/readme.md https://github.com/fullstackhero/dotnet-webapi-boilerplate/pull/625#discussion_r857447812 :

+with the new directories in place (and if not completely integrated in fullstackhero) +Add a reference to the Utils project in the host project

+in program.cs +Add 'using FSH.WebApi.Utils;' +Add 'builder.Services.AddUtils(builder.Configuration);' +Add 'await app.Services.InitializeGenerateSources();' '

I don't really understand why you would want the source generation in the host project? Surely source generation is something you would only want to do at development time... never at runtime?

I would think the source generator itself would be a cli utility (could even make an actual dotnet tool out of if)... which takes some parameters as to what to generate?

— Reply to this email directly, view it on GitHub https://github.com/fullstackhero/dotnet-webapi-boilerplate/pull/625#pullrequestreview-951608335, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABVNYOAJGPOFIZ4ZMJ63ZZDVGZS3BANCNFSM5UHNAY2Q . You are receiving this because you authored the thread.Message ID: @.*** com>

Stonne avatar Oct 11 '22 08:10 Stonne