script.elementum.jackett icon indicating copy to clipboard operation
script.elementum.jackett copied to clipboard

Fix log 'Skipped 1 duplicate messages..'

Open vasilky3 opened this issue 2 years ago • 1 comments

What i was trying to achieve is removing this annoying messages "Skipped 1 duplicate messages..":

2023-09-20 21:20:55.129 T:5172    debug <general>: [script.elementum.jackett] Jackett returned below response
2023-09-20 21:20:55.129 T:5172     info <general>: Skipped 1 duplicate messages..
2023-09-20 21:20:55.129 T:5172    debug <general>: [script.elementum.jackett] ===============================
2023-09-20 21:20:55.135 T:5172     info <general>: Skipped 1 duplicate messages..

As i understand the reason is: in some cases we are using from elementum.provider import log and it's calls elementum plugin code: https://github.com/vasilky3/plugin.video.elementum/blob/master/resources/site-packages/elementum/logger.py

meanwhile script.jackett logger also gets the same logger. And now we adding second handler to it. I think it causes double printing. More over if we are already using elementum.provider.log why creating one more logger it looks not DRY enough :)

I will revert changes. All this need to be done in separate PR.

Originally posted by @vasilky3 in https://github.com/fugkco/script.elementum.jackett/pull/21#discussion_r1350991945

vasilky3 avatar Oct 09 '23 23:10 vasilky3

fixed in https://github.com/fugkco/script.elementum.jackett/pull/32

vasilky3 avatar Oct 29 '24 14:10 vasilky3