theta icon indicating copy to clipboard operation
theta copied to clipboard

Adjust Codacy settings to match the coding style

Open as3810t opened this issue 5 years ago • 1 comments

Right now Codacy checks every pull request. However, Codacy's settings do not always match the coding conventions that Theta follows.

For example, the message below is a common error, that is reported for all creational static methods in the <Type>Exprs static classes:

The static method name 'Add' doesn't match '[a-z][a-zA-Z0-9]*'

As a result, as of now all the pull requests are merged with failing checks, disregarding the fact, whether they do or do not follow the conventions of Theta. This way, bogus errors might shadow actual problems with the code, and thus code with lower than standard quality might be merged to master.

as3810t avatar Sep 09 '20 21:09 as3810t

Agreed. I'm currently in progress of tuning these settings. However, sometimes it is difficult because of the granularity of the rules. For example, to silence warnings about methods starting with uppercase, the whole rule on checking method naming conventions must be turned off. Anyway, I will play around with it. Also, if you feel like it, you can take a look at the rules and give suggestions what to disable or enable.

hajduakos avatar Sep 10 '20 06:09 hajduakos