adlfs icon indicating copy to clipboard operation
adlfs copied to clipboard

Make AzureBlobFileSystem anon behaviour configurable via env var.

Open microft opened this issue 2 years ago • 5 comments

Making the anon default value configurable from an env var makes integration easier with helm charts that provide features like RBAC in Azure accounts.

In a multi-cloud application I am working on it is impacting that the code needs to change between AWS and Azure. The default in s3fs is anon=False, in adlfs anon=True.

This PR would allow for configuration only to change without any code change.

It would facilitate integration with https://azure.github.io/azure-workload-identity/docs/quick-start.html without any code change apart from environment variables.

microft avatar Nov 24 '23 14:11 microft

Are you able to add a test and docs?

I think pytest has a fixture to monkeypatch environment variables for a test. Just need to confirm that it gets set in __init__ properly.

TomAugspurger avatar Dec 02 '23 14:12 TomAugspurger

Checking in here, will you have a chance to update these last things @microft?

TomAugspurger avatar Dec 31 '23 13:12 TomAugspurger

Will try to update in the next few days. (Festivities plus child birth have kept me mostly offline)

microft avatar Dec 31 '23 15:12 microft

@TomAugspurger I got a test going, but the cachable property (inherited from AbstractFileSystem) seems to complicate testing multiple instances with the same account_name and connection_string. Hence the monkey patch on cachable for that test. Hope it makes sense.

microft avatar Feb 14 '24 23:02 microft

@TomAugspurger: Any idea when this can be approved and merged, please? It's affecting us badly, too.

r-priyam avatar Mar 21 '24 10:03 r-priyam

Thanks!

TomAugspurger avatar Apr 13 '24 12:04 TomAugspurger