Update All Packages lost unsaved changes

[JohanLarsson]

This is probably more a VS bug but here goes:

1. Edit some files but do not save them
2. Tools > Paket Dependencies Manager > Update All Packages

Think ^ is what I did, did not test if it is a repro. When the projects reloaded all unsaved changes were lost.

Suggested fix: Save or ask if user wants to save before running the command.

[forki]

actually I thought we close the projects before updating. this should have triggered the save functions.

[isaacabraham]

Yeah. I'm sure I raised a bug about this on the Paket VS repo a while ago, not sure if it was closed it bout, but I've seen this happening as well.

[forki]

    private void RunCommandAndReloadAllProjects(string helpTopic, Action<SolutionInfo> command)
    {
        PaketOutputPane.OutputPane.Activate();
        PaketErrorPane.Clear();
        StatusBarService.UpdateText("Paket command started.");

        var info = new SolutionInfo();
        info.Directory = SolutionExplorerExtensions.GetSolutionDirectory();
        info.FileName = SolutionExplorerExtensions.GetSolutionDirectory();
        var projectGuids = SolutionExplorerExtensions.GetAllProjectGuids();

        SolutionExplorerExtensions.SaveSolution();
        foreach (var projectGuid in projectGuids)
            SolutionExplorerExtensions.UnloadProject(projectGuid);

        System.Threading.Tasks.Task.Run(() =>
        {
            try
            {
                command(info);
                PaketOutputPane.OutputPane.OutputStringThreadSafe("Ready\r\n");
                StatusBarService.UpdateText("Ready");
            }
            catch (Exception ex)
            {
                PaketErrorPane.ShowError(ex.Message, info.FileName, helpTopic);
                PaketOutputPane.OutputPane.OutputStringThreadSafe(ex.Message + "\r\n");
            }
        }).ContinueWith(_ =>
        {
            foreach (var projectGuid in projectGuids)
                SolutionExplorerExtensions.ReloadProject(projectGuid);
        });
    }

that's weird...

[marhoily]

The bug is very annoying. Is there any chance for the fix?

[forki]

I'm happy to take PRs

[fourpastmidnight]

Heck, it's annoying enough to have all your open document tabs unceremoniously get closed, and then worst of all, they're not restored when Paket extension is done doing its thing. Pretty poor UX. Not a fan. NuGet can restore/update packages without closing the project--so what's the deal here?

[forki]

Nuget is using VS apis to add or remove references. That works to some degree but is also very flaky.

In the new csproj/fsproj project system with MSBuild 15 this is basically solved.

For this addin here I'm still waiting for someone to contribute a fix. I personally don't use the addin.