Parsing an integer value when JSON contains a decimal point

[giedriusbruzas]

let result : int ParseResult = parseJSON "1.1"
let (Choice1Of2 value) = result
//val value : int = 1

I feel this is incorrect and should instead result in a failure. There's possibly other similar edge cases like this one.

[wallymathieu]

This also causes trouble when trying to do lensing.

[wallymathieu]

JNumber s implies that s is JsonPrimitive ...

[wallymathieu]

Seems like F# Data us fixing this as well: https://www.nuget.org/packages/FSharp.Data/3.0.0-beta4 :

(Breaking Change) Don't silently convert decimals and floats to integers in JsonProvider.

[wallymathieu]

https://github.com/fsharp/FSharp.Data/pull/1185

[gusty]

I think this behavior is not correct at all. Anyway, I also think this should be corrected in the original library (as FSharp.Data just did). We should forward this issue to Newtonsoft and System.Json Also we should note that Fleece is a Json mapper for different libraries, since different libraries have different behavior (there is no agreed standard for Json <-> .NET) it's not up to Fleece to try to fix them.

[wallymathieu]

I agree. It only makes sense to align with the libraries. Right now JNumber active pattern has some interesting behavior.

[gusty]

I don't know if this is related:

1 |> toJson |> string;;
val it : string = "1"

but

(2,1) |> toJson |> string;;
val it : string = "[
  2.0,
  1.0
]"

[wallymathieu]

We also see this kind of behavior: https://github.com/JamesNK/Newtonsoft.Json/issues/1400 So I guess it's a tradeoff what Json parser you use.

[wallymathieu]

I've added a PR that documents the behavior. Note that Fsharp.Data works the way you want.