FSharpLint icon indicating copy to clipboard operation
FSharpLint copied to clipboard
verified publisher icon fsprojects

Upgrade FSharp.Compiler.Service to v43.8.200 to remove workaround in NoPartialFunctions rule

Open webwarrior-ws opened this issue 1 year ago • 4 comments

NoPartialFunctions needed a workaround because of a bug in FSharp.Compiler.Service library. In FSharp.Compiler.Service to v43.8.200 that has bug has been fixed.

This PR upgrades FCS to v43.8.200 and makes necessary changes to code. Workaround is removed. Packages FSharp.Core and Ionide.ProjInfo.* also had to be upgraded to latest stable versions.

webwarrior-ws avatar Feb 14 '24 14:02 webwarrior-ws

Even though this doesn't have conflicts, I'd prefer to get a rebase before merging, just to be on the safe side.

knocte avatar Mar 04 '24 12:03 knocte

Even though this doesn't have conflicts, I'd prefer to get a rebase before merging, just to be on the safe side.

Rebased.

webwarrior-ws avatar Mar 04 '24 12:03 webwarrior-ws

Can you move the commit NoPartialFunctions: remove workaround to be the last one please?

knocte avatar Mar 04 '24 22:03 knocte

Can you move the commit NoPartialFunctions: remove workaround to be the last one please?

Done

webwarrior-ws avatar Mar 05 '24 10:03 webwarrior-ws