FSharpLint icon indicating copy to clipboard operation
FSharpLint copied to clipboard

DRAFT: Add new rule C#-FriendlyAsyncOverload

Open parhamsaremi opened this issue 3 years ago • 3 comments

Fixes https://github.com/fsprojects/FSharpLint/issues/517

NOTE: this PR supersedes an older PR

parhamsaremi avatar Nov 18 '22 13:11 parhamsaremi

This PR needs to change because we're going to change the convention: instead of having Foo(): Async<'T> for the F# method and FooAsync(): Task<'T> for the C# one, we're gonna have AsyncFoo(): Async<'T>, FooAsync(): Task<'T>, and Foo(): 'T for the synchronous version. This conclusion comes from a debate between me and Afshin in this PR: https://github.com/nblockchain/NOnion/pull/56

knocte avatar Apr 16 '23 10:04 knocte

Not all the libraries are meant for C# use. For example type-providers, they just don't work in C#.

Thorium avatar Nov 18 '23 11:11 Thorium

Not all the libraries are meant for C# use. For example type-providers, they just don't work in C#.

Good point, that's why this rule won't be enabled by default.

knocte avatar Dec 29 '23 13:12 knocte