FSharpLint icon indicating copy to clipboard operation
FSharpLint copied to clipboard

DRAFT: adjust to find upcast new redundant

Open jp-fournier-dev opened this issue 3 years ago • 2 comments

  • Don't raise redundant new keyword if in an upcast expression and the type implements IDisposable
  • Add test to cover this use case

Fixes #572

jp-fournier-dev avatar Oct 21 '22 19:10 jp-fournier-dev

Good work! Is this PR finished? I ask because it's still marked as DRAFT, but I feel it can already be merged since you added a unit test and your code doesn't break any (old&new) tests.

knocte avatar Oct 22 '22 08:10 knocte

It does add a test but doesn’t really add anything. I’ll make it work properly and then we can merge and fix the issue

jp-fournier-dev avatar Oct 22 '22 12:10 jp-fournier-dev