FSharpLint icon indicating copy to clipboard operation
FSharpLint copied to clipboard

Add 2 new rules NestedFunctionNames and UnnestedFunctionNames

Open webwarrior-ws opened this issue 3 years ago • 7 comments

These rules allow configuring naming conventions for nested and unnested function names.

webwarrior-ws avatar Aug 03 '22 11:08 webwarrior-ws

LGTM, let's squash all commits into 1? (Use Co-authored-by: Name Surname <[email protected]> tag in commit message.)

knocte avatar Aug 10 '22 07:08 knocte

From 064444fec757bf273cf6e0d856838dea3179a214 Mon Sep 17 00:00:00 2001
From: webwarrior <[email protected]>
Date: Wed, 27 Oct 2021 06:48:56 +0200
Subject: [PATCH] Add 2 new rules NestedFunctionNames and UnnestedFunctionNames

These rules allow configuring naming conventions for nested and unnested function names.

Co-authored-by: Retheesh Erathu <[email protected]>

It should be the other way around: Retheesh be the author of the commit (as the majority of the code is his), but add yourself in the Co-authored-by tag.

knocte avatar Aug 10 '22 08:08 knocte

Why do I see 6 commits now in this PR instead of 1 or 2? Commit 31a1fba1cfd710b5c06a6105d66137314cb6cc6e looks correct and you should've used --amend to that one.

knocte avatar Aug 24 '22 08:08 knocte

Why do I see 6 commits now in this PR instead of 1 or 2? Commit 31a1fba looks correct and you should've used --amend to that one.

For some reason my local function-names branch was unsynchronized with remote one. So I pulled and pushed.

webwarrior-ws avatar Aug 24 '22 08:08 webwarrior-ws

And when pulling I guess you didn't use the flag --rebase.

knocte avatar Aug 24 '22 08:08 knocte

No

webwarrior-ws avatar Aug 24 '22 08:08 webwarrior-ws

That's the reason then. Please always use --rebase when pulling, otherwise it causes this kind of weird merges/messes.

knocte avatar Aug 24 '22 08:08 knocte

@webwarrior-ws can you rebase this please (also pls update the "Introduced in" text in docs).

knocte avatar Dec 07 '23 08:12 knocte

@webwarrior-ws can you rebase this please (also pls update the "Introduced in" text in docs).

ping

knocte avatar Dec 16 '23 04:12 knocte

@knocte Rebased on top of latest master branch.

webwarrior-ws avatar Dec 18 '23 10:12 webwarrior-ws