FSharp.Control.AsyncSeq icon indicating copy to clipboard operation
FSharp.Control.AsyncSeq copied to clipboard

Deprecate `FSharp.Control.IAsyncEnumerable` in favor of the same type in BCL

Open abelbraaksma opened this issue 3 years ago • 3 comments

Description

With the event of TaskSeq coming to the masses, which used the NetStandard 2.1 IAsyncEnumerable, using both this lib and that one leads to issues because the same type with slightly different semantics lives in FSharp.Control.

This can be very subtle, for instance if your AsyncSeq reference is transient, you may not even be aware that you’ve brought this type into scope. Then you think you open the namespace of FSharp.Control to access taskSeq and code starts failing with confusing messages (confusing, because the different types look the same and have the same name).

I propose to deprecate that type in a next major version. This will also mean dropping support for NetStandard 2.0 and moving to 2.1, or to accept multiple versions of this library.

/cc @dsyme

abelbraaksma avatar Nov 10 '22 18:11 abelbraaksma

@dsyme do you agree? Or who is the decision maker you assign? We are ready to take action and have V3 released

xperiandri avatar Nov 04 '24 16:11 xperiandri

Yes we should totally do this

dsyme avatar Nov 04 '24 20:11 dsyme

Don't even deprecate it, just replace it (with at most a type alias)

dsyme avatar Nov 04 '24 20:11 dsyme