Chessie icon indicating copy to clipboard operation
Chessie copied to clipboard

mergeMessages uses inconsistent ordering

Open generalelectrix opened this issue 9 years ago • 0 comments

Description

mergeMessages appends messages for error but prepends them for success

Expected behavior

mergeMessages should be consistent; IMHO it should always append them, as this is merging messages into an existing Result stream.

    let inline mergeMessages msgs result = 
        let inline fSuccess (x, msgs2) = Ok(x, msgs @ msgs2) // prepends
        let inline fFailure errs = Bad(errs @ msgs) // appends
        either fSuccess fFailure result

generalelectrix avatar Nov 03 '16 06:11 generalelectrix