FSharp.Stats icon indicating copy to clipboard operation
FSharp.Stats copied to clipboard

FR: Mann-Whitney-U test

Open omaus opened this issue 4 years ago • 3 comments

Please reference the issue(s) this PR is related to

Tackles #117

Please list the changes introduced in this PR

  • U test added

Description

Mann-Whitney-U test added to the Testing portfolio. Corresponding unit test as well.

  • [X] The project builds without problems on your machine
  • [X] Added unit tests regarding the added features

omaus avatar Jan 28 '22 15:01 omaus

I have been dealing with some issues in a different MannWhitney implementation and I fear that version isn't maintained. Is there anything I can do to help get this across the finish line? Might still be helpful to compare results with that implementation, since it has been otherwise fairly robust. Happy to help with testing and potentially any missing implementation details.

daz10000 avatar Apr 02 '25 02:04 daz10000

@daz10000 Yeah, I didn't work on this for a long time. I am also not really happy about the implementation since there are major issues with it: https://github.com/fslaborg/FSharp.Stats/pull/182/commits/d25e88ab1d6c902ed6d0c9db298f3a9b69d01dbe#r908169551 and https://github.com/fslaborg/FSharp.Stats/pull/182/commits/d25e88ab1d6c902ed6d0c9db298f3a9b69d01dbe#r795088327. Otherwise, the PR was/is okay I guess...

Links seem to not work properly (at least on my machine), therefore screenshots:

image

image

omaus avatar Apr 03 '25 09:04 omaus

I suspect half the work is in the last 10% for these things. Getting a basic version working vs getting something robust. I consider the R versions the gold standard for better or worse. I've come to the conclusion too that I might be abusing the test itself with the data sets I'm using which is probably for better or worse severely stressing implementations.

daz10000 avatar Apr 24 '25 03:04 daz10000