python-e3dc icon indicating copy to clipboard operation
python-e3dc copied to clipboard
verified publisher icon fsantini

S10 fixes

Open torbennehmer opened this issue 2 years ago • 4 comments

A number of fixes done for my HA integration to work cleanly.

fixes #73:

  • S10E Serial number detection did not work, a missing elif masked the corresponding check
  • A few exported classes were missing (notably SendError for error detection)
  • Calls to set_power_save and set_weather_regulated_charge were not correctly parsing the results from E3DC. (Did some code streamlining to those functions on the way)

torbennehmer avatar Apr 28 '23 10:04 torbennehmer

@vchrisb I have just created another PR without the changes around weather regulated charging. That should allow you to move on, while we get to the bottom of this here :)

#75 open

torbennehmer avatar May 07 '23 19:05 torbennehmer

@vchrisb How should we continue here, I still think we have some different behviour here depending on unit type. If this is easier for you, we could also take this discussion offline and do it in German language.

torbennehmer avatar Aug 16 '23 08:08 torbennehmer

If you need to test with yet another device (S10 X Compact 14), feel free to contact me :-)

eikowagenknecht avatar Sep 26 '23 12:09 eikowagenknecht