async-javascript-cheatsheet icon indicating copy to clipboard operation
async-javascript-cheatsheet copied to clipboard

Enable GitHub pages

Open felixfbecker opened this issue 7 years ago • 4 comments

This cheatsheet is great. If GitHub pages were enabled, one could directly view it in the browser in an accessible way (as opposed to the image which doesn't work with a screen reader).

felixfbecker avatar Oct 21 '18 14:10 felixfbecker

I do want to set this up so it's viewable on frontarm.com as HTML instead of an image, but it'll take a little work as the layout is currently hacked together to target "print as pdf" in Chrome.

Regarding accessibility, I think the current markup would need some work too, as the promises are just spans with a CSS class, so they'd be read as "value" instead of "promise to value". That could probably be fixed without my help, and I'd be glad to merge it in.

jamesknelson avatar Oct 21 '18 14:10 jamesknelson

I think it would be great even if it targets Print to PDF currently (would make it easy to do so without having to clone the repo) :)

felixfbecker avatar Oct 21 '18 14:10 felixfbecker

Probably also want to reference the Lato font as a webfont

felixfbecker avatar Oct 21 '18 14:10 felixfbecker

Referencing the Lato font makes sense. Will also need to add Fira Code. Unfortunately its not available on google web fonts so it'll take a little work.

jamesknelson avatar Oct 21 '18 14:10 jamesknelson