core icon indicating copy to clipboard operation
core copied to clipboard

Users can save the same URL multiple times in their list

Open maximevaillancourt opened this issue 5 years ago • 5 comments

Mentioned by dshannon on IndieHackers.

maximevaillancourt avatar Jul 01 '20 21:07 maximevaillancourt

@maximevaillancourt I can work on this, but could you please elaborate more like what will be the advantage of having same URL multiple times?

Chhekur avatar Oct 07 '20 06:10 Chhekur

@Chhekur Hey, thank you for jumping on this! 👋

It's actually the opposite - people can currently save the same URL to their list multiple times, but the behavior I'd prefer instead is that when someone saves an URL they already have in their list, it simply moves it up at the top of their list.

(in practical terms, this means saving the URL as usual, but looking through the user's saved articles to see if the same URL already exists, and if so, deleting the duplicates to only keep the most recent addition we just did)

Does that make sense?

maximevaillancourt avatar Oct 07 '20 11:10 maximevaillancourt

@maximevaillancourt yeah, it make sense but before deleting the old and storing latest one, we should at least show a confirmation message to user that you already had same URL. Do you want to overwrite or something, I guess.

Chhekur avatar Oct 07 '20 13:10 Chhekur

@Chhekur I'm fine with simply showing a flash message that says something like Looks like you already have this in your list - it's now at the top of your list and its expiry was reset 🙂

maximevaillancourt avatar Oct 07 '20 13:10 maximevaillancourt

@maximevaillancourt here's the PR #100 closes this issue

Chhekur avatar Oct 07 '20 14:10 Chhekur