frequency icon indicating copy to clipboard operation
frequency copied to clipboard
verified publisher icon frequency-chain

rpc: expose missing nonces in future pool

Open aramikm opened this issue 1 year ago • 1 comments

Goal

The goal of this PR is to expose missing nonces in future pool which causes problems when submitting a lot of transactions from the same account.

Closes #1974

Discussions

  • I had to remove node RPC test for events, since the setup fundamentally didn't work with the Pool and I added the removed test into e2e side.

Checklist

  • [X] Chain spec updated
  • [X] Custom RPC OR Runtime API added/changed? Updated js/api-augment.
  • [X] Tests added

aramikm avatar May 16 '24 23:05 aramikm

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

codecov[bot] avatar May 21 '24 01:05 codecov[bot]

LGTM. However, I’m a bit unclear on how this will benefit the client. It might be more effective for the client to keep track of transactions that have not yet been processed.

enddynayn avatar May 28 '24 21:05 enddynayn

LGTM. However, I’m a bit unclear on how this will benefit the client. It might be more effective for the client to keep track of transactions that have not yet been processed.

This will allow them to see if there are any transactions that are submitted using incorrect nonces. Tracking submitted transactions is not enough considering there might be more than 1 instance using the same account submitting to the chain.

aramikm avatar May 29 '24 17:05 aramikm