python-adguardhome icon indicating copy to clipboard operation
python-adguardhome copied to clipboard

Add ability to pause protection temporarily

Open kylehakala opened this issue 1 year ago • 1 comments

Proposed Changes

AdGuard has a GUI feature and REST endpoint that can be used to temporarily disable/pause protection for a specified amount of time. This change would enable the usage of that API.

Notes

This is just a quick crack at implementation — happy to hear any feedback on this and welcome any modifications.

Tests

I put together a basic test on this but wasn't quite happy with how it feels a bit half-tested. If there are any suggestions on how to better write that test, I am all ears!

kylehakala avatar Oct 20 '24 23:10 kylehakala

Hi @frenck — would you be open to merging in this functionality (or some variant)?

kylehakala avatar Oct 26 '24 02:10 kylehakala

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions.

github-actions[bot] avatar Nov 25 '24 08:11 github-actions[bot]

Hey @frenck, do you have any thoughts on this addition?

kylehakala avatar Dec 03 '24 15:12 kylehakala