fred icon indicating copy to clipboard operation
fred copied to clipboard

Added JAVADOC NOTICE about getting more notifications by implementing ClientE…

Open ktogias opened this issue 10 years ago • 3 comments

Making this pull request after xor-freenet's prompt on IRC. This is about getting detailed progress notifications with ClientPutCallback.

Added the following text to the comment at top of the class:



  • NOTICE: This interface provides onGeneratedURI, onGeneratedMetadata, onFetchable, onSuccess
  • and onFailure methods for getting notified about the progress of the insert process.
  • If you want to get more detailed progress notifications you have to also implement {@link ClientEventListener}
  • interface and subscribe your callback to the {@link ClientEventProducer} of the putter's
  • {@link InsertContext} using event producer's addEventListener method.
  • This way your callback will be able to receive the following events during the insert:
  • {@link ExpectedHashesEvent}, {@link StartedCompressionEvent}, {@link FinishedCompressionEvent}
  • and {@link SplitfileProgressEvent}.

ktogias avatar Sep 08 '15 10:09 ktogias

I would suggest to squash your last two commits so that the onSuccess/onFailure line is not touched at all.

Bombe avatar Sep 08 '15 13:09 Bombe

These commit messages do not meet the standards, but I'm willing to fix it for you if you like. I'll merge this once Bombe's points are addressed.

Thynix avatar Sep 16 '15 12:09 Thynix

@ktogias Ping.

Thynix avatar Nov 07 '15 23:11 Thynix