eyecite icon indicating copy to clipboard operation
eyecite copied to clipboard

Fix court string matching with whitespace

Open mattdahl opened this issue 2 years ago • 5 comments

As discussed in https://github.com/freelawproject/eyecite/issues/135#issuecomment-1386402484, there is presently a bug where court strings without whitespace are not properly matched. 3b2fe0972ebb86fad1a0beaa9942980398f38cbc implements a failing test for this bug. 94b1e2f16ddbd8005a6c5905a1621850c4adac9c implements a simple fix.

This PR is also related to the changes proposed in https://github.com/freelawproject/eyecite/pull/129, but I think that that proposal has been made obsolete with the removal of all the duplicate citation strings by @flooie (https://github.com/freelawproject/eyecite/issues/135#issuecomment-1404139512). In any case, this PR addresses a different problem re whitespace.

Note that this PR is based off of #143 (needed to update black to make GitHub Actions happy), so that should be merged first.

mattdahl avatar Feb 23 '23 22:02 mattdahl

@flooie looks like this one never got your approval. Mind taking a look, please?

mlissner avatar Jul 06 '23 12:07 mlissner

Want me to rebase this?

mattdahl avatar Jul 06 '23 17:07 mattdahl

That'd be great, thanks @mattdahl

mlissner avatar Jul 06 '23 17:07 mlissner

Thanks for merging that other PR, @flooie. I just rebased this one as well.

N.B., I previously suggested that #129 had been made obsolete by intervening changes. This is false. More notes over there.

mattdahl avatar Sep 22 '23 19:09 mattdahl

Thanks. I'll take a look soon.

flooie avatar Sep 22 '23 19:09 flooie