freeCodeCamp icon indicating copy to clipboard operation
freeCodeCamp copied to clipboard

hint for Learn Typography by Building a Nutrition Label - Step 50 needs a space between class names

Open hbar1st opened this issue 3 years ago • 14 comments

Describe the Issue

The first hint shown in step 50 of Learn Typography by Building a Nutrition Label places two class names together without any space in between so it is hard to read. The hint is shown if we do not enter any code and simply click on the Check Your Code button.

Hint You should create a new p element at the end of your .daily-value.sm-text element.

Affected Page

https://www.freecodecamp.org/learn/2022/responsive-web-design/learn-typography-by-building-a-nutrition-label/step-50

Your code

N/A

Expected behavior

Need to have a single space in between the two class names for better readability.

Screenshots

No response

System

N/A

Additional context

No response

hbar1st avatar Oct 14 '22 17:10 hbar1st

.daily-value.sm-text this is a selector for an element that has both classes, a space in between would change the meaning

majestic-owl448 avatar Oct 14 '22 18:10 majestic-owl448

It's a selector but for display purpose (hint text) we can separate them.

nayabatir1 avatar Oct 14 '22 18:10 nayabatir1

Or

You should create a new p element at the end of your element having the classes daily-value and sm-text.

I don't want to see a wrong selector, .daily-value .sm-text means the element with classe sm-text descendant of the element with class daily-value

majestic-owl448 avatar Oct 14 '22 18:10 majestic-owl448

div.daily-value it references only one dom node. If you feel like we can use this

nayabatir1 avatar Oct 14 '22 18:10 nayabatir1

I am going to change all the project soon, so this may even be a moot point...

majestic-owl448 avatar Oct 14 '22 19:10 majestic-owl448

Could just change it to .daily-value not sure why we need to mention both classes.

naomi-lgbt avatar Oct 15 '22 00:10 naomi-lgbt

Can you tell me how to improve my programming skills to start working for opensource organisations in gsoc i know programming languages but I am not able to solve issues

kanugurajesh avatar Oct 15 '22 06:10 kanugurajesh

Actually it would be helpful to repeat the instruction "after your last .divider" in the hint as when reading the current hint, the referenced element is not even in the current view (you have to scroll up past the editing region to find it)

hbar1st avatar Oct 15 '22 09:10 hbar1st

Could just change it to .daily-value not sure why we need to mention both classes.

I agree .daily-value is sufficient.

nayabatir1 avatar Oct 15 '22 10:10 nayabatir1

We could just change it to .daily-value .

SanskarJain007 avatar Oct 15 '22 12:10 SanskarJain007

We could just change that to .daily-value .

Kannan0017 avatar Oct 15 '22 19:10 Kannan0017

can i work on it

getcoder-top avatar Oct 17 '22 17:10 getcoder-top

please assign this issue to me

getcoder-top avatar Oct 17 '22 17:10 getcoder-top

@getcoder-top We typically do not assign issues. Instead, we accept the first pull request that comprehensively solves the issue.

Issues labelled with help wanted or first timers only are open for contributions.

Please make sure you read our guidelines for contributing. We prioritize contributors following the instructions in our guide. Join us in our chat room or the forum if you need help contributing - our community will be happy to assist you.

majestic-owl448 avatar Oct 17 '22 18:10 majestic-owl448