fredizzimo
fredizzimo
Can you try the Alacritty terminal https://github.com/alacritty/alacritty, it uses the same backend library https://github.com/rust-windowing/winit, for keyboard input as Neovide? So, if it does not work there either, we should report...
I think this might be fixed in Neovide main. We recently updated to latest winit there. And https://github.com/rust-windowing/winit/issues/41 was marked as fixed by https://github.com/rust-windowing/winit/pull/1583. I don't know if we need...
Does the menu introduced by https://github.com/rust-windowing/winit/pull/1583 show up? I think it should do that by default, otherwise it probably needs to be enabled with https://github.com/rust-windowing/winit/blob/2b2dd6b65dcb20f59219f963a9e90f15d1ad8e9a/src/platform/macos.rs#L342.
@kekscode, thanks, I does look like it's a Winit bug, but I will take a closer look later ``` TRACE [neovide::window::keyboard_manager] KeyEvent { physical_key: Code( Comma, ), logical_key: Character( ",",...
BTW, could you test if it works with some other expansion than `ü`? That is probably requires pressing a dead key on your real physical keyboard, and might be what...
@kekscode, are you able to test this PR? * https://github.com/neovide/neovide/pull/2310 There's one potential fix, although it's quite unlikely. But if you normally need to use cmd to type the character...
Yes, it needs changes to the code, the `EventLoop::new()` should be replaced with `EventLoopBuilder` and then setting `EventLoopBuilderExtMacOS::with_default_menu` to true. That should be easy for someone with a mac to...
@9m, Yes, I changed it in the render loop branch to use the builder https://github.com/neovide/neovide/blob/d322a50cb3fd2cb88ad20c67da5271e3c37421d6/src/window/mod.rs#L77-L79 The easiest way is probably if you create a PR that targets that branch.
@kekscode, I think you can use the artifacts from the CI on my fork, at the bottom of this https://github.com/fredizzimo/neovide/actions/runs/7667755299
It looks correct. I have no idea either, but in winit there's this code https://github.com/rust-windowing/winit/blob/8c8fb39fcd147fc86e722374cbd0632888299947/src/platform_impl/macos/app_state.rs#L468-L471 And the menu adds a quit option https://github.com/rust-windowing/winit/blob/master/src/platform_impl/macos/menu.rs And if I understand correctly, that should...