solidity-patterns icon indicating copy to clipboard operation
solidity-patterns copied to clipboard

requires updating?

Open grapevinegizmos opened this issue 3 years ago • 2 comments

Not sure if there is error, or just change in compiler, but in your code you've got strings, a b compared with return keccak256(a)==keccak256(b) which doesn't compile, needs `keccak256(bytes(a))==keccak256(bytes(b));

grapevinegizmos avatar May 01 '22 19:05 grapevinegizmos

@grapevinegizmos

As stated in the readme:

Disclaimer

This repository is not under active development anymore and some (if not most) sections might be outdated. There is no liability for any damages caused by the use of one of these patterns.

01231 avatar May 12 '22 10:05 01231

@fravoll I would volunteer to update the whole repository to the current Solidity version. What do you think?

01231 avatar May 12 '22 10:05 01231

Hey @noahliechti ! Thanks for your generous offer. As I could not vouch for the validity of your changes I would rather leave this in the 0.4.21 Version state that I created it. Maybe you could fork the repo and I could link your fork in the Readme!

fravoll avatar Mar 15 '23 13:03 fravoll