netfox icon indicating copy to clipboard operation
netfox copied to clipboard

Disabling Input Broadcast, breaks movement (at 150ms tick delay)

Open TheYellowArchitect opened this issue 1 year ago • 5 comments

I tried this on main branch, specifically commit https://github.com/foxssake/netfox/pull/241/files sudo tc qdisc add dev lo root netem delay 150ms with 3 players. The host always sees the clients properly, but the other 2 clients have problems with syncing their transforms. This bug takes many tries to replicate, on average 5.

desync-example

Full video example: https://youtu.be/YEIO446KJX4 Error log doesn't have anything useful, but posting for curiosity (its beceause of the desynced bombs at the end) error-log

Edit: repulse effect also stops working between clients (host is unaffected)

TheYellowArchitect avatar Sep 01 '24 18:09 TheYellowArchitect

Have you tried enabling input broadcasting back?

I did raise a similar issue on my initial pull request here: https://github.com/foxssake/netfox/pull/230#issuecomment-2254593890

Not saying that this is the solution to add it back but that might help figure out the issue if this is what is causing it.

nicobatty avatar Sep 02 '24 19:09 nicobatty

@TheYellowArchitect the video doesn't show up on my end :slightly_frowning_face: Could you try sharing it as an unlisted YT video or something else?

elementbound avatar Sep 02 '24 20:09 elementbound

Have you tried enabling input broadcasting back?

You are right, when it is enabled this bug doesn't happen, just tested and confirmed. So it was introduced in #230 and by extension its easier to bugfix since we know it's related to inputs :+1:

TheYellowArchitect avatar Sep 02 '24 21:09 TheYellowArchitect

@TheYellowArchitect the video doesn't show up on my end 🙁 Could you try sharing it as an unlisted YT video or something else?

It's something with browsers not supporting that video's encoding. I reuploaded and replaced the previous link.

TheYellowArchitect avatar Sep 02 '24 21:09 TheYellowArchitect

I want to add that the repulse effect also stops working if input broadcast is disabled

Update: Solved by #284

TheYellowArchitect avatar Sep 04 '24 14:09 TheYellowArchitect

@TheYellowArchitect I've updated @284, could you please check if the issue still persists on that branch?

elementbound avatar Nov 08 '24 13:11 elementbound

The bug doesn't happen in both implementations of #284

TheYellowArchitect avatar Nov 13 '24 19:11 TheYellowArchitect