go-imap-sql icon indicating copy to clipboard operation
go-imap-sql copied to clipboard

Don't pass empty strings to go-imap

Open ptrcnull opened this issue 2 years ago • 4 comments

closes #44 closes #46

ptrcnull avatar Sep 11 '23 01:09 ptrcnull

actually, it still doesn't fix the whole issue:

* 11295 FETCH (UID 31113 FLAGS ( \Seen nonjunk) BODYSTRUCTURE ("text" "html" ("charset" "UTF-8") NIL NIL "quoted-printable" 35910 779 NIL NIL NIL NIL) ENVELOPE ("Sat, 09 Sep 2023 22:12:10 +0000" "[RESOLVED]  (Disk usage)" (("Grafana" NIL "grafana" "ptrc.gay")) (("Grafana" NIL "grafana" "ptrc.gay")) (("Grafana" NIL "grafana" "ptrc.gay")) ((NIL NIL "alerts" "ptrcnull.me")) NIL NIL NIL "<[email protected]>"))

you might notice the FLAGS parenthesized list still having an empty element at the beginning

ptrcnull avatar Sep 11 '23 01:09 ptrcnull

haha, nevermind, this PR somehow makes thunderbird just outright.. not pull messages from the server it doesn't error out or anything

EDIT: it's just that last commit, apparently...

ptrcnull avatar Sep 11 '23 11:09 ptrcnull

fixed it

ptrcnull avatar Sep 11 '23 11:09 ptrcnull

tested with:

  • Thunderbird 115.2.0
  • aerc 0.15.2
  • K-9 Mail 6.602
  • alps 652ea9c7 ( go-imap v2 )

ptrcnull avatar Sep 11 '23 11:09 ptrcnull