Elliot Hillary

Results 24 comments of Elliot Hillary

That's a very good point - I think this would be good as another separate rule. Conceptually, the motivations are a bit different: the reason for using `Default(T)` to initialize...

I did actually consider this when initially making the proposal, which is why the name of the rule is so vague 😄 I decided not to include it because of...

> After thinking about it some more, there can be cases where certain algorithm may ignore the some of the first elements. It's definitely smelly to do that, but hard...

The easiest solution would be not to do any type resolution at all, and check the user-provided signature against the exact text of the declaration. For example, for the following:...

Don't believe so. [This](https://docwiki.embarcadero.com/RADStudio/en/Annotating_Types_and_Type_Members) was the only reference I could find to this syntax feature, and it doesn't venture an opinion: ![image](https://github.com/integrated-application-development/sonar-delphi/assets/28214458/90cc7cc5-2b98-4bfd-b5b8-c9fde2308003)

Also, I'm not sure if you've noticed @jgardn3r but there are still a few unresolved conversations from @Cirras 's first round of review.

@simonegirlanda, just to clarify - #377 will likely resolve most of your false positive issues. That being said, there may still be unexpected gaps in the analysis (false positives, false...

- Added to the default quality profile, and - Added a test that `Pred(X.Count)` does not add an issue

One thing I forgot to note - I removed support for binary character escapes (e.g. `#%11101110`) since as far as I can tell Delphi does not recognise them.