api icon indicating copy to clipboard operation
api copied to clipboard

Country Phone Codes

Open sivajyothika opened this issue 1 year ago • 5 comments

Hi , For country , I want to add one more API called country phone code which gives the phone codes of countries example (India : 91 , USA : 1,UK : 44 )

This is the approach :

method: get
title: Country Phone Code Dictionary
desc: Fetch the country phone code dictionary where country names are keys and the respective phone codes are the values corresponding to the keys.
path: country/phonecodes

sivajyothika avatar May 18 '24 03:05 sivajyothika

Yes you can add it .. we already have the data in foss42-core https://github.com/foss42/foss42-core/blob/c38af576f2311c4185bec8c17f72042ead453124/foss42/data/geo/country.py#L266

ashitaprasad avatar May 18 '24 18:05 ashitaprasad

Yes you can add it .. we already have the data in foss42-core https://github.com/foss42/foss42-core/blob/c38af576f2311c4185bec8c17f72042ead453124/foss42/data/geo/country.py#L266

Sure will do that

sivajyothika avatar May 18 '24 18:05 sivajyothika

Please assign me this issue.

lassmara avatar May 27 '24 19:05 lassmara

I would love to work on it.Please assign this issue to me.

shashbh18 avatar Jun 24 '24 05:06 shashbh18

Hi Ashitaprasad

I noticed that the implementation of the country phone code API requested on May 18 hasn't been completed yet. To help move things forward, I have created a pull request that addresses this.

The new API endpoint I've added is: Method: GET Title: Country Phone Code Dictionary Description: Fetches the country phone code dictionary where country names are keys and the respective phone codes are the values corresponding to the keys. Path: /country/phonecodes

Please review the pull request at your earliest convenience and let me know if there are any changes or improvements needed. Thank you!

Best regards, Eman Ali

bro-maanii avatar Jun 25 '24 06:06 bro-maanii