nodejs-dns-over-https-tangerine icon indicating copy to clipboard operation
nodejs-dns-over-https-tangerine copied to clipboard
verified publisher icon forwardemail

[feat] Add typescript support

Open nikelborm opened this issue 1 year ago • 3 comments

Describe the feature

Hi! I like the library very much and I'm open to cover it with typescript type definitions (and help maintaining those types in the future), so it will have great auto-completion in IDEs and also it will improve documentation along the way.

Are you open for accepting this contribution?

nikelborm avatar Jul 17 '24 14:07 nikelborm

PR is welcome

titanism avatar Jul 17 '24 18:07 titanism

Ok, I'll create a PR soon

nikelborm avatar Jul 18 '24 08:07 nikelborm

@nikelborm it would also be great for us to get tests working again, not sure if you can help with that 😅

also see v1.5.5 we just released which fixed some core bugs and allowed us to upgrade to latest version of undici

https://github.com/forwardemail/nodejs-dns-over-https-tangerine/releases/tag/v1.5.5

titanism avatar Aug 03 '24 07:08 titanism

PR welcome

titanism avatar Nov 12 '24 20:11 titanism

@titanism this was closed as completed, but I don't see any PRs on this repo.

dknell avatar Jan 27 '25 15:01 dknell

Yes we're closing it because TypeScript is garbage and unless someone adds a PR we're not going to bother keeping issues like these open.

titanism avatar Jan 27 '25 18:01 titanism