react icon indicating copy to clipboard operation
react copied to clipboard

Two loading spinners are displayed

Open madflow opened this issue 1 year ago • 5 comments

Describe the bug

  • When using a recent version of this library and @formio/js two loading spinners are displayed for a single form.

To Reproduce

  git clone [email protected]:formio/react-app-starterkit.git
  cd react-app-starterkit
  yarn
  yarn run dev

or with a fresh vite create

{
  "name": "formio-vite",
  "private": true,
  "version": "0.0.0",
  "type": "module",
  "scripts": {
    "dev": "vite",
    "build": "tsc -b && vite build",
    "lint": "eslint .",
    "preview": "vite preview"
  },
  "dependencies": {
    "@formio/js": "^5.0.0",
    "@formio/react": "6.0.0-rc.1",
    "react": "^18.3.1",
    "react-dom": "^18.3.1"
  },
  "devDependencies": {
    "@eslint/js": "^9.17.0",
    "@types/react": "^18.3.18",
    "@types/react-dom": "^18.3.5",
    "@vitejs/plugin-react": "^4.3.4",
    "eslint": "^9.17.0",
    "eslint-plugin-react-hooks": "^5.0.0",
    "eslint-plugin-react-refresh": "^0.4.16",
    "globals": "^15.14.0",
    "typescript": "~5.6.2",
    "typescript-eslint": "^8.18.2",
    "vite": "^6.0.5"
  }
}
@import "@formio/js/dist/formio.full.min.css";
    <Form src="https://examples.form.io/example" />

Expected behavior

  • It shows one loading spinner.

Screenshots

Kapture 2025-01-07 at 14 47 08

Sandbox Example Desktop (please complete the following information): Smartphone (please complete the following information): Additional context

madflow avatar Jan 07 '25 13:01 madflow

Thanks for the report @madflow If someone wants to contribute a fix I'll have our devs review it.

lane-formio avatar Jan 15 '25 13:01 lane-formio

@lane-formio I am looking for some open source projects to work on. If this is issue is still open and hasn't been resolved, I'm interested in contributing to this issue.

shraddhak1989 avatar Mar 24 '25 04:03 shraddhak1989

@lane-formio will be working on this..

silky-x0 avatar May 12 '25 12:05 silky-x0

I think you need to look to elmente isLoading if you are using twice this.

klejdig1 avatar May 21 '25 10:05 klejdig1

@lane-formio will be working on this..

I'm not working on this.

@shraddhak1989 offered though 😃

If I see a PR come in for it I'll make sure it gets reviewed/merged.

lane-formio avatar May 21 '25 13:05 lane-formio