former icon indicating copy to clipboard operation
former copied to clipboard
verified publisher icon formers

Configurable URL absolute or relative paths

Open gpassarelli opened this issue 6 years ago • 4 comments

Enabled relative URL support with config param and as a function param. Keeping the same behavior as Laravel route and action helper functions. As a fallback, it keeps the original behavior of always returning absolute paths;

gpassarelli avatar Jun 17 '19 15:06 gpassarelli

Well I really needed this feature, How come it has not been confirmed?

hshahdoost avatar Jul 12 '20 07:07 hshahdoost

At first glance, this PR looks decent other than missing tests. @hshahdoost have you tested it and verified it's working well for you? Would you be willing and able to add tests?

claar avatar Jul 27 '20 16:07 claar

I have tried it, and it was working just fine, But since it wasn't in the library I took a different approach, I see if I'll can write tests for it.

hshahdoost avatar Jul 28 '20 12:07 hshahdoost

Hi @hshahdoost if you are still interested, I've merged the latest master changes so the tests will pass, will you still be able to add tests or is this feature no longer needed for you?

stayallive avatar Nov 30 '20 20:11 stayallive

Closing this PR because it is quite old and it has been a long time since there was any activity, if there is still interest please do re-open the PR!

stayallive avatar Mar 22 '24 11:03 stayallive