smart_contract icon indicating copy to clipboard operation
smart_contract copied to clipboard

OMG transferFrom interface is not have return bool value

Open baoliang opened this issue 7 years ago • 0 comments

Hi, When i deposit the OMG TOKEN https://etherscan.io/address/0xd26114cd6EE289AccF82350c8d8487fedB8A0C07 , i find run error, i find out The OMG source transferFrom function not return any ,

contract ERC20 is ERC20Basic {
  function allowance(address owner, address spender) constant returns (uint);
  function transferFrom(address from, address to, uint value);
  function approve(address spender, uint value);
  event Approval(address indexed owner, address indexed spender, uint value);
}

but the ERC20 interface is require return bool type value. I find out this project deposit function's ERC20 interface is return bool value. It run for deposit OMG will error. seems

    require(IToken(token).transferFrom(msg.sender, this, amount));

baoliang avatar Aug 02 '18 17:08 baoliang