forge icon indicating copy to clipboard operation
forge copied to clipboard

bug: when disconnecting display, detaches all existing windows from tree

Open jmmaranan opened this issue 4 years ago • 5 comments

It looks like the workareas-changed event reloads the tree but it should still check if the display monitor is available or listen to display connected/disconnected signals.

This use case happens when user uses a KVM switch (desktop single monitor shared with a laptop)

Nov 02 14:12:14 pop-os gnome-shell[164790]: Forge: [DEBUG] matched rules 1
Nov 02 14:12:14 pop-os gnome-shell[164790]: Forge: [DEBUG] adding workspace: ws0
Nov 02 14:12:14 pop-os gnome-shell[164790]: Forge: [DEBUG] initialized monitors: 0
Nov 02 14:12:14 pop-os gnome-shell[164790]: Forge: [DEBUG] adding workspace: ws1
Nov 02 14:12:14 pop-os gnome-shell[164790]: Forge: [DEBUG] initialized monitors: 0
Nov 02 14:12:14 pop-os gnome-shell[164790]: Forge: [DEBUG] adding workspace: ws2
Nov 02 14:12:14 pop-os gnome-shell[164790]: Forge: [DEBUG] initialized monitors: 0
Nov 02 14:12:14 pop-os gnome-shell[164790]: Forge: [DEBUG] adding workspace: ws3
Nov 02 14:12:14 pop-os gnome-shell[164790]: Forge: [DEBUG] initialized monitors: 0
Nov 02 14:12:14 pop-os gnome-shell[164790]: Forge: [DEBUG] initialized workspaces: 4
Nov 02 14:12:14 pop-os gnome-shell[164790]: Forge: [INFO] forge initialized
Nov 02 14:12:14 pop-os gnome-shell[164790]: Forge: [DEBUG] created keybindings
Nov 02 14:12:14 pop-os gnome-shell[164790]: Forge: [DEBUG] extension:enable
Nov 02 14:12:14 pop-os gnome-shell[164790]: Forge: [DEBUG] keybindings:enable
Nov 02 14:12:14 pop-os gnome-shell[164790]: Forge: [DEBUG] stylesheet reloaded /home/jmmaranan/.local/share/gnome-shell/extensions/[email protected]/stylesheet.css
Nov 02 14:12:14 pop-os gnome-shell[164790]: Forge: [INFO] enable: finalized vars

jmmaranan avatar Nov 02 '21 18:11 jmmaranan

Hi, my windows gets reset when I lock and unlock my desktop (external monitor connected to laptop with lid closed). It happens when the display switches off while locked - I mean when I have it locked for some time. I expect it may be caused by this problem, right? Btw thank you for a great extension!

baldimir avatar Dec 20 '21 10:12 baldimir

My hunch is that when locked for a long time, the USB or Display Connectors gets disconnected, power saving etc, and work areas event gets triggerred. Where the reset tree function is being called.

jmmaranan avatar Dec 20 '21 19:12 jmmaranan

@baldimir - thank you for your support!

jmmaranan avatar Dec 20 '21 23:12 jmmaranan

Hi, I get this behavior when workspaces are added or removed. I thought it might be related, so I replied here. It's pretty annoying, because I tend to use workspaces in a dynamic way and my layouts get reset to the default column layout continuously.

I'm using GNOME 41 on Wayland.

EllBock avatar Apr 21 '22 14:04 EllBock

Hi, I get this behavior when workspaces are added or removed. I thought it might be related, so I replied here. It's pretty annoying, because I tend to use workspaces in a dynamic way and my layouts get reset to the default column layout continuously.

I'm using GNOME 41 on Wayland.

Added support for dynamic workspaces so it does not reset the tree when adding/removing workspaces.

jmmaranan avatar Sep 27 '22 23:09 jmmaranan