big-dipper icon indicating copy to clipboard operation
big-dipper copied to clipboard

Ledger integration

Open kwunyeung opened this issue 6 years ago • 3 comments

Logins

  • [x] login with ledger
    • [x] prompt user when ledger account is different from the logged in one
    • [x] indicate that the viewing account address is user's own account

staking

  • [x] delegate to a validator
  • [x] undelegate from a validator
  • [x] redelegate to another validator
    • [x] add memo field
    • [x] add warning for undelegation/redelegation
    • [x] add link to transaction page after broadcast
    • [x] error messages
    • [ ] ability to customize gas_adjustment or modify gas after simulation
  • [ ] show delegations info on validator list page if logged in
    • [ ] maybe add a 'delegated' filter in addition to 'active' 'inactive'?
    • [ ] show delegated shares/percentage in the table?

others

  • [x] send tokens

  • [x] withdraw rewards

  • [x] submit proposal

  • [x] vote a proposal

  • [ ] 1-click redelegation (withdraw and delegate again to a particular validator)

kwunyeung avatar May 19 '19 08:05 kwunyeung

@ztsai please also check what level of gas price should be set. I kind a like the estimate gas fee from lunie. Currently our sentry set the minimum gas price to 0.0.025uatom. You may take this as reference.

kwunyeung avatar May 29 '19 05:05 kwunyeung

@kwunyeung there's a simulating step before transaction which sets the estimate gas fee. I also added a follow up enhancement task in which that user can customize rate of gas_adjustment or modify gas after simulation (I am adding sub tasks as I go in the main thread of this issue, but let me know if there's a better way to track it)

ztsai avatar May 30 '19 03:05 ztsai

Seems not very easy to track everything here. I pinned this issue and reference all new related issues here. Those issues will be in the Cosmos Wallet or Delegator Dashboard projects as well

kwunyeung avatar Jun 10 '19 05:06 kwunyeung