big-dipper icon indicating copy to clipboard operation
big-dipper copied to clipboard

Charting Component

Open ztsai opened this issue 6 years ago • 1 comments

  • [x] if plottable is not reviewing pull request fast enough, publish forked plottable to npm and use that instead serve local version of plottable.js (#79)
  • [ ] validate props
  • [ ] add tests
    • [ ] add a dev only page that shows various applications of chart as simple e2e test
    • [ ] unit test and integration test
  • [ ] break it down, modularize, and refactor
    • [ ] handle errors better than just throw a string
  • [ ] there are multiple places on update where we need to decide if passing null/undefined serves as removal or noop
  • [ ] add tickGenerator for scales
  • [ ] add render to canvas option for supported plots
  • [ ] calculate dataset color using fill/stroke for different type of plots
  • [ ] add tooltip
  • [ ] auto populate domain/range for legend's colorscale given a PlotGroup
  • [ ] better comparison on updates to improve performance
  • [ ] detach/destroy components/listeners on componentWillUnmount

currently have a minimal working component at #66 and an application #67

ztsai avatar May 09 '19 15:05 ztsai

I will review the PRs this weekend, need to kill some issues and features planned before. In case they are not reviewed and merged, we talk again on Monday.

kwunyeung avatar May 10 '19 06:05 kwunyeung