LibreraReader icon indicating copy to clipboard operation
LibreraReader copied to clipboard

Page border color setting is not exposed

Open WhitespaceQ opened this issue 1 year ago • 3 comments

Librera has a virtual page that can be zoomed in/out when reading epub, this page has border with color that cannot be altered and it is a distraction in a pure black AMOLED theme.

Screenshot_2024-11-15-02-25-39-289_com foobnix pro pdf reader-edit I've tried looking through app-Librera.css but haven't find any relevant styling for the pages.

I recommend:

  1. Expose the page border size and color through setting
  2. Comment the css used in the apps with the description and where they're applied

Zoomed out, full screen view of the page border in question:

Screenshot_2024-11-15-03-14-04-191_com foobnix pro pdf reader-edit

WhitespaceQ avatar Nov 14 '24 19:11 WhitespaceQ

seconding this; it's pretty distracting while reading in pure black.

argonfilm avatar May 19 '25 06:05 argonfilm

Go to reader settings > Advanced Settings > Disable Night mode enhancement for Amoled Display.

Then you'll no longer see the page border. @argonfilm @WhitespaceQ

1chione avatar Jul 18 '25 14:07 1chione

Tracking the enhancements_for_oled_display option key from string translation, I've found that isOLED key is used twice in https://github.com/foobnix/LibreraReader/blob/6b512733826e61549d8b420820e11d75c805a05e/app/src/main/java/com/foobnix/pdf/search/activity/PageImaveView.java#L364-L368 and https://github.com/foobnix/LibreraReader/blob/6b512733826e61549d8b420820e11d75c805a05e/app/src/main/java/org/ebookdroid/core/EventDraw.java#L83-L87

If that's the case then the border will only be drawn if enhancements_for_oled_display=TRUE and invert_color=FALSE

Still haven't understand for why the logic is set up that way and whether changing the hard-coded color (to expose the option) will have unintended effect.

WhitespaceQ avatar Jul 23 '25 15:07 WhitespaceQ