foo86
Test files are not in release tarballs
Running make check in the source tree extracted from the 0.2.0 release tarball yields this:
mkdir -p libdcadec
gcc -o test/stddev -O2 -Wall -Wextra test/stddev.c -lm
cd test && ./test.sh
ERROR: Run 'git submodule update --init test/samples' first.
Makefile:161: recipe for target 'check' failed
It would be great if the release tarballs included the missing files from the Git submodule so that users can run the test suite before installing. Thanks!
The test samples are kind of big, so it wouldn't be practical to include them…
@TimothyGu Really? they're 2mbs...
and if that's STILL too big, use DCACut to cut out a single frame of each sample, and get rid of the WAV originals and just store their hash...
(preferably both their MD5 and SHA256 in the extremely unlikely case of collusions.)
Edit: I just zipped the untouched DTS samples and it only took up 437kb... (using OS X's default compression settings)
Using a hash sounds good. It is not big big, but 437kB is almost twice the size of the source tarball 220kB.
That's a good point, we should try slimming it down.
I just went through xll_71_24_96_768.dtshd (which is 54 kb) and scanned for XLL and ExSS magic numbers, and there are 7 of them, so I mean it wouldn't be crazy to cut it down to just one frame, which should drop the file size to roughly 8KB or so...
It's actually kinda strange because there are 7 frames for 4096 samples, which would be one frame at best, 4 at worst in LBR...