Django-Verify-Email icon indicating copy to clipboard operation
Django-Verify-Email copied to clipboard

New packaging

Open leolivier opened this issue 1 year ago • 2 comments

Modernized packaging using only build and github action

leolivier avatar Aug 10 '24 09:08 leolivier

Hi, this PR fixes the incompatibility with Django 5.1 + allows verification of emails for existing inactive users without forms (inspired by previous PRs which contained bugs) and modernized the packaging. There are a lot of files changed just because for the modernization of pacjackging, I had to move the verify_email folder inside a src folder. The number of really changed files is very low (4 I think) The github workflow is also modified in order to publish the package on test.pypi.org instead of pypi on a simple push, while creating a release will deploy it on pypi. Also, the connection to github is modernized using a token, so you have to create a token in github and store it in the project secrets

IMPORTANT! On this modernization topic, to check it worked and as I had no right to publish a new version on PyPi for the project, I had to change the project name in pyproject.toml and use django-email-validation instead of Django-Verify-Email (and you can test this package django-email-validation with version 2.0.4 to check it works). So if this PR is accepted, the name must be changed back to the initial value before delivering...

leolivier avatar Aug 10 '24 10:08 leolivier

Yoooo! thanks for all the changes and suggestions man! Lemme review these

knownbug06 avatar Nov 03 '24 16:11 knownbug06