lighthouse-check-action icon indicating copy to clipboard operation
lighthouse-check-action copied to clipboard

This github action doesn't read the configFile

Open stixaw opened this issue 2 years ago • 1 comments

Describe the bug Here is my Code in the config file:

  extends: 'lighthouse:default',
  settings: {
    skipAudits: [
      'is-on-https',
      'redirects-http',
      'uses-http2',
    ],
  },
}

here is how I am calling it in the github workflow:

       uses: foo-software/[email protected]
       id: lighthouseCheck
       with:
         configFile: ./lh-config-feature.js
         outputDirectory: ${{ env.LIGHTHOUSE_REPORTS_DIRECTORY }}
         urls: "http://chg-pde-comphealth-feature-${{ env.FEATURE_ID }}.s3-website-us-west-2.amazonaws.com"

Expected behavior I should see a report which doesn't show the HTTPS results but it occurs every time in our feature branches. They are on aws and can't do https.

I looked at the documentation for the lighthouse and for this action and from what I can tell it supports the use of the config file.

stixaw avatar Jul 05 '23 19:07 stixaw

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Aug 12 '23 13:08 stale[bot]

We need to update our documentation, but newer versions of this GitHub Action, this option is called overridesJsonFile and an example is here.

adamhenson avatar May 03 '24 16:05 adamhenson