region-flags icon indicating copy to clipboard operation
region-flags copied to clipboard

Streamline svg icons / Some svg flag icons are broken

Open josefglatz opened this issue 9 years ago • 4 comments

I can agree with https://github.com/TYPO3/TYPO3.Icons/issues/282, that some svg icons needs a viewBox to not break in some browsers.

Instead of duplicating the issue, I just reference it, is it is already explained in detail: https://github.com/TYPO3/TYPO3.Icons/issues/282 https://github.com/TYPO3/TYPO3.Icons/issues/283

josefglatz avatar Feb 14 '17 08:02 josefglatz

The files are auto-downloaded from Wikipedia (Wikimedia Commons). That said, we can fix the source by uploading a fixed version.

Is it one problem (missing viewBox) or also other issues? Do you have a script for the fix?

behnam avatar Feb 14 '17 08:02 behnam

Hi, thx for your fast response. Ah I see. Do you suggest to fix it at wikipedia or in your repo? Actually I have no script for the fix.

josefglatz avatar Feb 14 '17 08:02 josefglatz

We don't maintain a local source for the files, so, if only fixed here in the repo, it would get overridden on the next update, or, if marked locally, then not getting upstream updates. So, I say we better fix the files on Wikipedia. (Also benefiting other users of the file.)

Do you know how many files are broken? If just a few, we can fix manually. If more, better to have a script.

behnam avatar Feb 14 '17 08:02 behnam

I try to take care of it

josefglatz avatar Feb 16 '17 09:02 josefglatz